Skip to content

E2E: dismiss the first-run cookie banner so the Windows desktop test passes - #9

Merged
carthworks merged 1 commit into
mainfrom
claude/pensive-shannon-afywuj
Oct 6, 2026
Merged

carthworks merged 1 commit into
mainfrom
claude/pensive-shannon-afywuj

Conversation

@carthworks

Copy link
Copy Markdown
Owner

The first Windows run of the desktop end-to-end test failed. The packaged app, the bundled backend and the setup screen all came up. Then the new cookie-consent banner covered the Create Account & Initialize button, so the click timed out with "cookie-consent-overlay subtree intercepts pointer events".

This change registers a Playwright addLocatorHandler for the banner. Whenever the banner appears, the handler clicks Reject Non-Essential, the way a user would. The banner shows up after a 1.2 s delay, so a one-off dismiss would race it; a handler doesn't.

The full suite passes 5/5 locally against current main, using the packaged Linux app under xvfb.

Product note, not changed here: on smaller windows the banner also covers the login form for real users. Options are to give the banner room, or to skip it in the desktop app, which sends nothing off the machine.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jze3nDgZGqUXGceiu5RCAf


Generated by Claude Code

The consent banner added on main covers the Create Account button on the
Windows runner, so the click timed out. Dismiss it the way a user would
(Reject Non-Essential) whenever it shows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jze3nDgZGqUXGceiu5RCAf
@ecc-tools

ecc-tools Bot commented Oct 6, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 219fbc19dcb3503dbbf4a353eb1aabdfc113e23a

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 1 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 6, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 219fbc19dcb3503dbbf4a353eb1aabdfc113e23a

PR taxonomy review recommended (neutral)

Detected 1 PR taxonomy bucket(s): CI/CD Recommendation.

Scanned 1 changed file(s).

Roadmap taxonomy buckets:

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • 1 CI or workflow path(s) changed

Paths:

  • e2e/desktop.spec.js

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
libra-digit-ai Ready Ready Preview Oct 6, 2026 6:57am UTC

@ecc-tools

ecc-tools Bot commented Oct 6, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 219fbc19dcb3503dbbf4a353eb1aabdfc113e23a

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 1 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Oct 6, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 219fbc19dcb3503dbbf4a353eb1aabdfc113e23a

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 1 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@carthworks
carthworks merged commit 1ff91c1 into main Oct 6, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 219fbc19 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants