Add bank accounts modal and table

[dahal]

We currently have placeholder modal for bank accounts, we need to complete this feature. Completing this feature means:-

• Complete the Add bank account modal
• Render current bank accounts on a table
• Table will have these columns, with following headers

  • Bank name

  • Account number

  • Empty header, but rows should render Primary if primary is true, else Secondary. These primary/secondary should be rendered using Badge component. success for primary and info for secondary

  • Actions, with drop down actions (similar to API Key table)

    • Edit, this will render the same modal, with pre filled data which will allow users to update existing bank account information.
    • Delete (self-explainatory) complete the flow by completing the trpc delete request.

You can get to this page by going to Settings > Bank accounts after you login

[Raju-kadel-27]

Just to inform, @Alfredoeb9 is working on this issue.

[rushikeshg25]

@Raju-kadel-27 I can help in with this. Please assign me this if there is inactivity for a long time. Sry for the ping

[dahal]

@Alfredoeb9 are you picking this up or can @rushikeshg25 help? Please confirm.

[Alfredoeb9]

@dahal I am picking this up just waiting for my other PR to merge before I continue on this task.

[Alfredoeb9]

@dahal on the new bank modal screen, do I include the respected BankAccount Table schema as inputs? (beneficiaryName, beneficiaryAddress, bankName, bankAddress, companyId etc.)

[dahal]

Yes please. Company id is only to establish association.

[Alfredoeb9]

Some other edge cases for the routing numbers and account number will there be a maxLength limit?
When doing a search looks like Routing numbers are always 9 digits long. Account numbers may be up to 17 digits long.

[dahal]

Some other edge cases for the routing numbers and account number will there be a maxLength limit? When doing a search looks like Routing numbers are always 9 digits long. Account numbers may be up to 17 digits long.

Is this universal or only specific to US accounts, if its universal we can have that validation. @Alfredoeb9

[Alfredoeb9]

Some other edge cases for the routing numbers and account number will there be a maxLength limit? When doing a search looks like Routing numbers are always 9 digits long. Account numbers may be up to 17 digits long.

Is this universal or only specific to US accounts, if its universal we can have that validation. @Alfredoeb9

Let dig deeper on that, it didnt specify the country

Edit: After some research looks like every country has different max digits. ex. In Germany and Austria, Germany has 8 digits, Austria has 5. In Canada max digits are 8. In India 11-character code with the first four characters representing the bank name, and the last six characters representing the branch.

With this I won't be putting a maxLength on the fields

[Alfredoeb9]

@dahal Before I continue to connecting to backend, is this UI approved?

I added in a confirm routing number as that seems to be standard across other 'Add Bank Account' services.

[dahal]

@dahal Before I continue to connecting to backend, is this UI approved?

I added in a confirm routing number as that seems to be standard across other 'Add Bank Account' services.

Looks good, we dont need the company name though. @Alfredoeb9