vesting dao mint#404
Merged
Merged
Conversation
Collaborator
|
is it ready? @andrewnguyen22 as some tests are failing on the CI |
pablocampogo
requested changes
May 22, 2026
Collaborator
Author
|
Review re-requested @rem1niscence @pablocampogo @ezeike |
rem1niscence
requested changes
May 22, 2026
rem1niscence
left a comment
Collaborator
There was a problem hiding this comment.
everything looks all right in general, just set it as request changes to enforce the response of the comments. Also in general, I'm pretty sure you did but just to double confirm, as there's a possibly high amount of places where account balances are manipulated in general, did you make sure that all these places have the checks for vesting in place? wether to view those accounts or manipulate them in any way
rem1niscence
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds vesting-aware account support and a mint option for DAO transfer proposals.
What Changed
Vesting accounts
DAO transfer minting
Why
Vesting
The chain needs to distinguish between:
This PR keeps total ownership at the storage layer while enforcing spendability dynamically based on vesting schedule and height.
DAO minting
This gives validators a controlled way to approve exceptional treasury grant events that require new issuance, without creating a separate
governance message type.
Testing
Covered with focused tests for: