Issue #154#155
Merged
Merged
Conversation
rem1niscence
requested changes
Apr 23, 2025
Collaborator
rem1niscence
left a comment
There was a problem hiding this comment.
First set of review, most of them are minor clarifications and warnings, so far it looks pretty good! second one coming shortly
Co-authored-by: Roniel Valdez <roniel_valdez@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempts to fix the following:
Related Issues
Closes: #154
Changes Made
RootChainInforetrieval from http polling to websockets pub/subRootChainInfostruct to protobuf for faster marshallingChecklist
issue-#<issue-number>.npm run prettierto format the web-wallet and/or block explorer (if applicable)Additional Notes
Still testing - will run in docker soon.