chore: refresh Go module dependencies - #677
Draft
motrilense wants to merge 2 commits into
Draft
motrilense wants to merge 2 commits into
motrilense wants to merge 2 commits into
Conversation
…anonical#672) Routine maintenance bump of Go dependencies across the two Go services to keep them current with upstream releases. maasagent - `golang.org/x/net` -> v0.56.0 - `golang.org/x/text `-> v0.39.0 - `google.golang.org/grpc` -> v1.79.3 - OpenTelemetry stack -> v1.43.0 (with exporters/prometheus -> v0.65.0) - Align the agent's OpenTelemetry resource `semconv` import (v1.26.0 -> v1.40.0) to match the updated SDK's default resource schema maasopenfga - `github.com/jackc/pgx/v5` -> v5.9.0 - `golang.org/x/net` -> v0.53.0 - `golang.org/x/text` -> v0.39.0 - `google.golang.org/grpc` -> v1.80.0 - OpenTelemetry stack -> v1.43.0 All updated modules require Go ≤ 1.25 (MAAS uses Go 1.26).
Follow-up to [canonical#672](canonical#672), continuing the refresh of the Go module dependencies. ## Changes Both `src/maasagent` and `src/maasopenfga`: - `google.golang.org/grpc` --> `v1.83.2` - `go.opentelemetry.io/otel` (+ `metric`, `sdk`, `sdk/metric`, `trace`) --> `v1.44.0` - `golang.org/x/net` --> `v0.58.0` - `golang.org/x/text` --> `v0.41.0` - `golang.org/x/sync` --> `v0.22.0` - `golang.org/x/sys` --> `v0.47.0` OpenTelemetry exporters aligned to the `v1.44.0` core: - `maasagent`: `go.opentelemetry.io/otel/exporters/prometheus` --> `v0.66.0` - `maasopenfga`: `go.opentelemetry.io/otel/exporters/otlp/otlptrace` and `.../otlptracegrpc` --> `v1.44.0` One accompanying code change in `src/maasagent/internal/daemon/daemon.go`: the `semconv` import is moved from `v1.40.0` to `v1.41.0` to match the schema URL that the OpenTelemetry SDK requires. ## Notes - gRPC `v1.83.2` requires `golang.org/x/net v0.58.0`, `otel v1.44.0`, `x/sync v0.22.0`, `x/sys v0.47.0` and `x/text v0.41.0` in its own `go.mod`, so those versions are the minimums resolved by `go mod tidy` for each module's graph (not a hand-forced alignment) - The OpenTelemetry exporters are bumped alongside the core so the whole OTel graph stays on `v1.44.0`; this also prunes the leftover `otel v1.43.0` from `maasopenfga/go.sum`. `otlptracegrpc v1.44.0` pulls `grpc-gateway/v2` to `v2.29.0` as a required transitive - All bumped versions keep the `go 1.26` directive; none require a newer toolchain
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
[maas-code-reviewer review]
LLM-generated review from https://github.com/canonical/maas-code-reviewer.
Intended to assist a human reviewer, not replace one — suggestions may be
incorrect, please verify before acting.
Overall, the dependency bumps look good and go mod tidy appears to have been run successfully across both modules.
A few minor observations:
- The PR description mentions
semconvwas updated fromv1.40.0tov1.41.0, but the diff insrc/maasagent/internal/daemon/daemon.goshows it actually replacingv1.26.0. - A few dependencies were bumped in
src/maasagent/go.modbut are not listed in the PR description (e.g.golang.org/x/toolstov0.48.0,github.com/prometheus/client_golangtov1.23.2, andgithub.com/stretchr/testifytov1.11.1). - Since
go.opentelemetry.io/otelwas bumped tov1.44.0, please ensure thatgo.temporal.io/sdk/contrib/opentelemetry v0.6.0(which remains unbumped inmaasagent) is fully compatible with this newer SDK version during your testing. While core OpenTelemetry APIs are backwards compatible, contrib modules sometimes rely on specific SDK versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance bump of Go dependencies (backport of #672 + #675 to 3.8).
Changes
Both
src/maasagentandsrc/maasopenfga:google.golang.org/grpc-->v1.83.2go.opentelemetry.io/otel(+metric,sdk,sdk/metric,trace) -->v1.44.0golang.org/x/net-->v0.58.0golang.org/x/text-->v0.41.0golang.org/x/sync-->v0.22.0golang.org/x/sys-->v0.47.0Only
src/maasopenfga:github.com/jackc/pgx/v5-->v5.9.0OpenTelemetry exporters aligned to the
v1.44.0core:maasagent:go.opentelemetry.io/otel/exporters/prometheus-->v0.66.0maasopenfga:go.opentelemetry.io/otel/exporters/otlp/otlptraceand.../otlptracegrpc-->v1.44.0One accompanying code change in
src/maasagent/internal/daemon/daemon.go: thesemconvimport is moved fromv1.26.0tov1.41.0to match the schema URL that the OpenTelemetry SDK requires.