Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
skyecas
force-pushed
the
fix/dhcpd-sock-cleanup
branch
2 times, most recently
from
September 21, 2026 12:47
48605ec to
b6e765d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
skyecas
force-pushed
the
fix/dhcpd-sock-cleanup
branch
from
September 21, 2026 13:00
b6e765d to
ac74107
Compare
- Unlink notification socket on service stop to prevent stale sockets - Clean up stale sockets on rackd startup (deb equivalent of snap's run-rackd) - Handle partial socket states in start() (close and remove on Chmod failure) - Catch FileNotFoundError/ConnectionRefusedError in maas-dhcp-helper Resolves LP:2167838
skyecas
force-pushed
the
fix/dhcpd-sock-cleanup
branch
from
September 21, 2026 13:05
ac74107 to
8b1d732
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Move conn.connect() inside closing() block in helper - Add PermissionError catch in helper - Fix server.py imports to top-level, add logging - Fix test_server.py to actually test exception path with mock - Add stderr assertion to helper dir-missing test
alemar99
approved these changes
Sep 22, 2026
skyecas
enabled auto-merge
September 22, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminating the
configure-dhcp-serviceleaves an orphaned socket file on disk, causing cascading failures.This adds an explicit socket unlink to storp() to ensure downstream attempts aren't failed.
Additionally add clearer failure logging so this issue is easier to debug in future
Resolves LP:2167838