fix(network): Relax Constraints for Resizing Dynamic Range Reservations for v3 API - #347
Open
bryanfraschetti wants to merge 1 commit into
Open
bryanfraschetti wants to merge 1 commit into
bryanfraschetti wants to merge 1 commit into
Conversation
Collaborator
|
Check where you would like a Mattermost message to be sent to when CI completes and this PR is merged
|
bryanfraschetti
force-pushed
the
fix_dynamic_range_resizing_v3_api
branch
from
June 11, 2026 12:57
57c9f37 to
6a06534
Compare
bryanfraschetti
force-pushed
the
fix_dynamic_range_resizing_v3_api
branch
2 times, most recently
from
July 29, 2026 21:12
781e1b9 to
cafe11b
Compare
bryanfraschetti
force-pushed
the
fix_dynamic_range_resizing_v3_api
branch
from
July 30, 2026 16:19
cafe11b to
bb03e0a
Compare
Contributor
|
@bryanfraschetti it is time to rebase this PR now before someone from the MAAS team reviews your PR. Thanks 🙂 |
bryanfraschetti
force-pushed
the
fix_dynamic_range_resizing_v3_api
branch
2 times, most recently
from
August 20, 2026 14:10
121ca7f to
c14576b
Compare
Contributor
Author
|
@skatsaounis Thanks 🙂 Just rebased |
Contributor
|
@alemar99 could you please review this PR based on your past contributions to API v3 IP ranges? |
alemar99
requested changes
Sep 21, 2026
alemar99
left a comment
alemar99
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the contribution!
Just a nit on module imports and then we can merge it
| MISSING_PERMISSIONS_VIOLATION_TYPE, | ||
| ) | ||
| from maasservicelayer.models.auth import AuthenticatedUser | ||
| from maasservicelayer.models.ipranges import IPRange as IPRangeModel |
| ValidationException, | ||
| ) | ||
| from maasservicelayer.models.auth import AuthenticatedUser | ||
| from maasservicelayer.models.ipranges import IPRange as IPRangeModel |
…ns LP: #2143090 for v3 API
bryanfraschetti
force-pushed
the
fix_dynamic_range_resizing_v3_api
branch
from
September 22, 2026 14:20
c14576b to
26fbca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the validation logic for resizing (expanding / shrinking) dynamic range reservations in the v3 api
Related PR: #280
Resolves LP #2143090