pre-commit: initialize (Infra)#2433
Closed
Saviq wants to merge 1 commit into
Closed
Conversation
tomli380576
reviewed
May 19, 2026
| - id: check-yaml | ||
| args: [--allow-multiple-documents] | ||
| - id: check-added-large-files | ||
| - repo: https://github.com/psf/black |
Contributor
There was a problem hiding this comment.
there's a mirror that's allegedly 2x as fast: https://github.com/psf/black-pre-commit-mirror
- repo: https://github.com/psf/black-pre-commit-mirror
rev: # version num here
hooks:
- id: black
Collaborator
|
Sorry for coming to this late. We don't want pre-commit hooks in Checkbox at all, we've discussed this internally multiple times but in our opinion don't fit with the way we work. The decision is not final as many others, but for now I'd say no. Thanks for working on this any way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rather than rely on people remembering to run linters/formatters, and maintain a separate config in Actions, use https://pre-commit.com hooks to standardize.
pre-commit installlocally to validate every commit.If you configure https://github.com/apps/pre-commit-ci-lite to have access to this repo, it will even autofix PRs.
pre-commit run --all-filesis quite unhappy at the moment, but that's out of scope for this PR.Resolved issues
N/A
Documentation
N/A
Tests
N/A