feat: Sigma rules pt.2#467
Draft
MichaelThamm wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <copilot@github.com>
MichaelThamm
commented
May 8, 2026
| labels = rule.get('labels', {}) | ||
| assert labels.get('juju_model') == MODEL_NAME | ||
| assert labels.get('juju_model_uuid') == MODEL_UUID | ||
| assert labels.get('juju_application') == 'otlp-provider' |
Contributor
Author
There was a problem hiding this comment.
Should this be otlp-requirer?
MichaelThamm
commented
May 8, 2026
| build-backend = "hatchling.build" | ||
|
|
||
| [tool.hatch.metadata] | ||
| allow-direct-references = true |
Contributor
Author
There was a problem hiding this comment.
Remove when done testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Add the testing for the prior PR:
Builds on this PR:
Solution
Add the feature.
Checklist
project.versionfield in thepyproject.tomlfile..adddoesn't have it in its call pathContext
Testing Instructions
Testing of the SigmaRules class is achieved in:
This PR adds tests for the charmlib-scoped responsibilities.
Upgrade Notes