Iterative json read#210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an iterative (streaming) reader for Checkbox session JSON using ijson, aiming to avoid loading the entire gzipped session file into memory and enabling alternative session-reading implementations behind a shared interface.
Changes:
- Add
ijsonas a runtime dependency (and updateuv.lock) to support streaming JSON parsing. - Refactor Checkbox session reading into an
AbstractCheckboxSessioninterface with two implementations: in-memory and iterative. - Update app state logic to rely on the new session interface and use the new
list_jobs(...)API.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| uv.lock | Locks ijson and its distribution artifacts for reproducible installs. |
| src/bugit_v2/models/app_state.py | Uses the new session abstraction and switches job listing to list_jobs(...). |
| src/bugit_v2/checkbox_utils/checkbox_session.py | Introduces AbstractCheckboxSession and the new streaming CheckboxSessionIterative implementation. |
| pyproject.toml | Adds ijson>=3.5.0 to project dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.