Visual tweaks#209
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a set of UI/layout tweaks across the Textual screens and widgets, including showing the test plan during job selection and adjusting the file picker presentation.
Changes:
- Add a “Test Plan” label to the job selection screen and thread the test plan value through
AppState -> JobSelectionScreen. - Adjust bug report screen layout to place the additional-files picker at a different nesting level.
- Update file picker modal/widget styling and layout (CSS, button variants, and dynamic spacing based on selection state).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/bugit_v2/screens/job_selection_screen.py |
Adds test_plan parameter/field and displays it in the header area. |
src/bugit_v2/models/app_state.py |
Passes session/submission test plan into JobSelectionScreen. |
src/bugit_v2/screens/bug_report_screen.py |
Adjusts the placement/indentation of the additional files picker in the compose tree. |
src/bugit_v2/components/file_picker.py |
Adds modal CSS + messaging, tweaks buttons, adds a “pick files” row with dynamic spacing, and updates deselect button styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
80
| app_blob = json.loads( | ||
| base64.b64decode(self.session_json["session"]["metadata"]["app_blob"]) | ||
| ) | ||
| try: | ||
| self.testplan_id = app_blob["testplan_id"] | ||
| except KeyError as e: | ||
| raise KeyError( | ||
| f"{self} is missing field(s): {', '.join(e.args)}.", | ||
| ) | ||
| try: | ||
| self.testplan_id = app_blob["testplan_id"] | ||
| except KeyError as e: | ||
| raise KeyError( | ||
| f"{self} is missing field(s): {', '.join(e.args)}.", | ||
| ) | ||
| else: | ||
| logger.error(f"{self} does not contain valid information.") | ||
| self.failed_jobs = self.get_run_jobs() |
Collaborator
Author
There was a problem hiding this comment.
do this in a different pr
Comment on lines
+9
to
+12
| @final | ||
| class CompactButton(Button): | ||
| DEFAULT_CSS = """ | ||
| CompactButton { |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.