fix(130845): update Simnet Key Value fixture for Operation field

[keesverruijt]

Why CI is red

canboat #697 (fd9bde4) reshaped PGN 130845 Simnet: Key Value: field 9 was renamed MinLength → Operation (a SIMNET_KEY_OPERATION lookup: 0 Read, 1 Set, 2 Reply) and the spare9 field was dropped.

The earlier fix 645ae09 ("simrad tests failing because of canboat changes") updated 130850.js but missed 130845.js, so the canboat "Test canboatjs…" workflow still fails with 4 errors:

• decode (from pgn 130845): output now has operation: 'Set' and no minlength/spare9.
• encode (to pgn 130845): the stale minlength/spare9 keys are unknown → ignored, so the Operation byte encodes as 0xff instead of the expected 0x01.

The fix

Update test/pgns/130845.js (both entries) to use operation: 'Set' and drop minlength/spare9. Set = wire byte 0x01, which matches the existing input sample (…,12,00,01,58), so the encode round-trip is preserved.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated test expectations for parsed PGN data to reflect the current Backlight level field format.
  • Confirmed two cases now expect operation: Set with the same value: 88, replacing older expected fields.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 647a32b7-d07a-40ae-bd59-b28949d01f39

📥 Commits

Reviewing files that changed from the base of the PR and between c584d70 and 96ee328.

📒 Files selected for processing (1)

• test/pgns/130845.js

---

📝 Walkthrough

Walkthrough

Two test case expectations in the PGN 130845 fixture are updated: the fields for key: 'Backlight level' now include operation: 'Set' before value: 88, replacing previously expected minlength and spare9 fields.

Changes

PGN 130845 test fixture

Layer / File(s)	Summary
Backlight level field expectations test/pgns/130845.js	Both test cases updated to expect operation: 'Set' alongside value: 88 for the Backlight level field, removing previous minlength/spare9 expectations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

test

Poem

🐇 A field called "operation" hopped into the test,
Replacing spare9 and minlength — good riddance, they joked!
"Set" is the value, now clearly expressed,
The backlight shines brighter, the fixture invoked.
With two lines updated, the rabbit's at rest! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the fixture update for PGN 130845 and the new Operation field expectation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/130845-operation-fixture

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

test/pgns/130845.js

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}