Skip to content

Fixed uncaught dup key with caracal @ develop #140 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhishekPanta8 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed uncaught dup key with caracal @ develop #140 #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion service/database/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ class Mongo {
const res = await collection.insertMany(data);
return res;
} catch (e) {
if (silent) {
if (e.code === 11000) {

@birm birm Mar 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably only silently return if 'silent' is true

@AbhishekPanta8 AbhishekPanta8 Mar 31, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes true, I have handled that case in else if statement.

console.warn(`Duplicate key error in collection '${collectionName}': ${e.keyValue}`);
return;
} else if (silent) {
console.warn('insert into ' + collectionName + ' did not occur, continuing because silent set')
} else {
console.error(e);
Expand Down