fix: allow unregistering the navigation delegate#336
Merged
Conversation
hurali97
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit support for releasing Brownfield navigation delegate ownership, addressing scenarios where multiple native hosts (Activities/scenes) may alternately own navigation and must not leave stale delegates registered.
Changes:
- Introduces
clearDelegate()on both iOS and Android navigation managers. - Updates native integration docs to describe ownership-based lifecycle registration/clearing patterns.
- Updates the Android and iOS sample apps to register/unregister delegates based on host lifecycle.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/brownfield-navigation/references/native-ios-integration.md | Updates iOS integration guidance to include ownership-based delegate clearing. |
| skills/brownfield-navigation/references/native-android-integration.md | Updates Android integration guidance to clear delegate on lifecycle teardown. |
| packages/brownfield-navigation/ios/BrownfieldNavigationManager.swift | Adds clearDelegate() API on iOS manager. |
| packages/brownfield-navigation/android/src/main/java/com/callstack/nativebrownfieldnavigation/BrownfieldNavigationManager.kt | Adds clearDelegate() API on Android manager. |
| docs/docs/docs/api-reference/brownfield-navigation/native-integration.mdx | Expands docs with lifecycle ownership contract and updated snippets. |
| apps/AppleApp/Brownfield Apple App/BrownfieldAppleApp.swift | Moves delegate registration to scenePhase ownership and clears on inactive/background. |
| apps/AndroidApp/app/src/main/java/com/callstack/brownfield/android/example/MainActivity.kt | Moves delegate registration to onResume and clearing to onPause. |
| .changeset/quiet-papayas-unite.md | Adds a patch changeset for the navigation package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #307
Introduced a new API:
Test plan
CI passes