Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept
screenshot --crop-on <selector>on physical iOS devices. Adds a measured geometry fixture and updates tests, help and documentation: 7 files. Refs #2276.The
ios-physicalcell also admits physical iPadOS. No iPad, including Split View, was verified.Validation
Retested unmodified
7ffc88bedf4dfe7459961e5a7d6dc3b0e8fdd130on 2026-10-19: clean checkout, freshly rebuilt CLI, isolated daemon/session, normal CoreDevice capture route; no forced-runner patch.Device: physical iPhone 12 (iPhone13,2), iOS 27.0.1 (24A446), Xcode 26.6 (17F113), wired. App: fiddl gallery. Snapshot viewport: 390×844 pt;
23 objectsbounds: approximately (255.6667, 73.6667, 54.3333, 14.3333) pt.From that checkout, with
$UDIDselecting the test phone:Both exited 0. The CLI returned
success: true, width 163, height 43. Independent raw capture: 1170×2532.Comparing decoded pixels against raw origin (767, 221): all 7,009 RGBA pixels identical, maximum channel difference 0, mean absolute RGB difference 0. Controls: one row down 8.0689; one crop-height down 21.9517. Best ±4 px offset: (0, 0).
Existing
pnpm check:affected --run --head 7ffc88bereceipt: passed, Node 22.20,exactCommit=true. GitHub-only/manual lanes were skipped, not passed.This replaces the provisional base-plus-local-change evidence. The legacy
xctestdevice backend remains unverified.