Skip to content

fix(build): resolve tsdown vendor alias with fileURLToPath - #3629

Merged
thymikee merged 1 commit into
callstack:mainfrom
kkkhs:agent/fix-tsdown-windows-alias-3353
Oct 15, 2026
Merged

thymikee merged 1 commit into
callstack:mainfrom
kkkhs:agent/fix-tsdown-windows-alias-3353

Conversation

@kkkhs

@kkkhs kkkhs commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #3353.

The tsdown alias for @limrun/xdelta3-wasm now resolves the fixture URL with fileURLToPath() instead of URL.pathname, so file:///C:/... becomes a Windows drive-letter path rather than /C:/.... Touched files: 1.

Validation

Tested on 12e626979.

base 542fb77b3 expression head 12e626979 expression
URL.pathname -> /C:/repo/src/vendor/limrun-delta-sync-omitted.ts fileURLToPath(..., { windows: true }) -> C:\repo\src\vendor\limrun-delta-sync-omitted.ts

Passed: pnpm format:check, pnpm lint, pnpm typecheck, pnpm build, pnpm check:bundle-owner-files, pnpm check:package, pnpm check:mcp-metadata, pnpm check:gate-manifest, pnpm check:gate-manifest:test, git diff --check.

pnpm check:affected --run reached Fallow and stopped because this host's glibc 2.28 is below the bundled Fallow binary's GLIBC_2.29/2.30 requirement; earlier runnable gates passed. Not run on native Windows here.

View guided diff

Signed-off-by: Huangshuo Kuang <141250392+kkkhs@users.noreply.github.com>
@kkkhs
kkkhs marked this pull request as ready for review October 15, 2026 04:06
Copilot AI balanced review requested due to automatic review settings October 15, 2026 04:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

@thymikee

Copy link
Copy Markdown
Member

This PR is ready for review at 12e6269. The tsdown alias now uses fileURLToPath, and I found no problems in the change. All checks pass, and the build job exercises the changed alias path. There are no conflicts. I did not run the Windows build locally.

Not blocking: scripts/fuzz/envelope.ts:112 and one test still use the new URL(import.meta.url).pathname pattern. You can switch those two sites to fileURLToPath in a follow-up, or leave them.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 15, 2026
@thymikee
thymikee merged commit f24b9e2 into callstack:main Oct 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: tsdown vendor alias uses URL.pathname, which breaks pnpm build on Windows

3 participants