Reduce db conn pool size and increase max conns#630
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts PostgreSQL connection limits and SQLAlchemy per-process pooling to mitigate “too many clients” errors in the backend stack.
Changes:
- Increase Postgres
max_connectionsto 300 indocker-compose.yml. - Reduce SQLAlchemy
pool_size/max_overflowto 5/5 per worker process inbackend/app/db.py. - Add
TODO.mdandAGENTS_filesto.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker-compose.yml |
Raises Postgres max_connections to better tolerate aggregate connections across multiple worker processes. |
backend/app/db.py |
Lowers per-process SQLAlchemy pool limits to reduce total concurrent DB connections across workers. |
.gitignore |
Ignores local TODO/agent-generated artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+26
| # Each worker process gets its own pool, so keep per-process limits modest: | ||
| # with 12 workers (8 backend + 4 backend-dvc), 5 + 5 = 10 per process gives a | ||
| # 120-connection worst case, comfortably under the db's max_connections (300). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to a too many clients error.