Deprecate disableSSLRedirect with sslRedirect - #105
Open
nilathedragon wants to merge 1 commit into
Open
nilathedragon wants to merge 1 commit into
nilathedragon wants to merge 1 commit into
Conversation
Member
Fine by me |
Contributor
Author
Member
It may be too much spam 😅, the convert function may be called many times so I think we should log this warning in another way, like only if config changed. That would mean having a list of deprecation messages to log somewhere 🤔 I'm not sure on how to do that... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For issue #102
Should we log a deprecation notice if we detect ingress objects using the old annotation?
Could be done easily in matcher.go if we add a zap logger to the plugin.