Skip to content

[chore] Adopt C++23 as the default standard #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kexianda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore] Adopt C++23 as the default standard #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ endif()
# Required so bolt code can be used in a dynamic library
set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 23)
set(CMAKE_CXX_STANDARD_REQUIRED True)

# execute_process( COMMAND bash -c "( source
Expand Down
2 changes: 0 additions & 2 deletions bolt/common/memory/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ add_executable(
StreamArenaTest.cpp
)

target_compile_features(bolt_memory_test PRIVATE cxx_std_20)

if(NOT APPLE)
find_package(jemalloc CONFIG REQUIRED)
endif()
Expand Down
1 change: 0 additions & 1 deletion bolt/common/token/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,5 @@
# limitations under the License.

bolt_add_library(bolt_token_extractor ITokenExtractor.cpp)
target_compile_features(bolt_token_extractor PRIVATE cxx_std_20)

target_link_libraries(bolt_token_extractor xxHash::xxhash Folly::folly)
2 changes: 0 additions & 2 deletions bolt/exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ bolt_add_library(
WindowPartition.cpp
)

target_compile_features(bolt_exec PRIVATE cxx_std_20)

set_target_properties(bolt_exec PROPERTIES ENABLE_EXPORTS ON)

if(${ENABLE_BOLT_JIT})
Expand Down
2 changes: 0 additions & 2 deletions bolt/exec/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ add_executable(bolt_exec_unested_test Main.cpp UnnestTest.cpp)

add_executable(bolt_exec_table_writer_test Main.cpp TableWriteTest.cpp)

target_compile_features(bolt_exec_test PRIVATE cxx_std_20)

add_executable(
bolt_exec_infra_test
AssertQueryBuilderTest.cpp
Expand Down
1 change: 0 additions & 1 deletion bolt/functions/prestosql/json/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ target_link_libraries(
sonic-cpp::sonic-cpp
Folly::folly
)
target_compile_features(bolt_functions_json PRIVATE cxx_std_20)

if(${BOLT_BUILD_TESTING})
add_subdirectory(tests)
Expand Down
3 changes: 0 additions & 3 deletions bolt/functions/prestosql/types/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@

bolt_add_library(bolt_presto_types HyperLogLogType.cpp JsonType.cpp TimestampWithTimeZoneType.cpp)

# JsonType.cpp needs to rely on the concept attribute in C++20
target_compile_features(bolt_presto_types PRIVATE cxx_std_20)

find_package(ryu CONFIG REQUIRED)

target_link_libraries(
Expand Down
1 change: 0 additions & 1 deletion bolt/jit/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ if(${ENABLE_BOLT_JIT})
RowContainerIRTest.cpp
ThrustJITv2Test.cpp
)
target_compile_features(bolt_thrustjit_test PUBLIC cxx_std_20)
target_link_libraries(
bolt_thrustjit_test PRIVATE
bolt_testutils
Expand Down
Loading