[fix] support hash table spill before hash probe#589
Open
guhaiyan0221 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #577
Type of Change
Description
Background
After HashBuild finishes building and before HashProbe starts, the build-side hash table remains resident in HashJoinBridge waiting to be consumed by the probe side. Currently, this resident hash table memory cannot be reclaimed by the node-level memory reclaimer, which may cause task OOM under memory pressure.
This PR supports spilling the hash table that has already been published to HashJoinBridge but has not yet been consumed by HashProbe. This allows memory arbitration to reclaim this memory before HashProbe starts.
Changes
1. Support bridge-level hash table spill
HashBuild::finishHashBuild()before publishing the hash table, and pass it toHashJoinBridge::setHashTable().HashJoinBridge:tableSpillFunc_tableSpillInProgress_probeStarted_HashJoinBridge::reclaim()triggers resident hash table spill when all of the following conditions are met:2. Support fallback to bridge reclaim in HashJoinMemoryReclaimer
HashJoinMemoryReclaimernow holds the correspondingHashJoinBridge.HashJoinBridge::reclaim()to try to reclaim the hash table that is still waiting in the bridge before probe starts.3. Reuse spill stats accumulation logic
OperatorStats::addSpillStats()to extract and reuse the spill stats accumulation logic fromaddSpillDetails().HashBuild::stats(clear).Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes