Adding Flatpak Support#119
Conversation
|
Hi there, Any update on this? This would be a really nice feature to have. |
|
If I'm honest, I just kinda forgot about it |
|
Thanks for your honesty! Would it be difficult to finish the pending
feature?
…On Sun, Feb 18, 2024 at 8:25 AM s e ***@***.***> wrote:
If I'm honest, I just kinda forgot about it
—
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4KKQIOIX4YOEL6MPQYB5LYUITP5AVCNFSM53HXGYWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGEZTONRWGM3A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I was basically done with it, the big thing is I'm going to have to deal with all the merge conflicts so it's up to date. |
|
Just gotta fix some small edge case type things, otherwise it's basically working |
| } | ||
|
|
||
| fn create_src_archive(settings: &Settings) -> crate::Result<()> { | ||
| Command::new("cargo").args(["vendor"]).output().ok(); |
There was a problem hiding this comment.
One thing of note here is that this does not support path dependencies rust-lang/cargo#10134, so those will be missing when trying to build the flatpak in isolation.
There was a problem hiding this comment.
I don't really think I'll be able to do much to fix this, but I'll make a warning that will show up if path dependencies are detected.
| tarfile | ||
| .append_dir_all("vendor/src", "src") | ||
| .chain_err(|| "src directory couldn't be put in archive")?; |
There was a problem hiding this comment.
This isn't necessarily enough. For example, my project should include build.rs and ui/ui.slint.
I'm not sure what the best way to fix this would be, maybe a list like resources only that it isn't put into a separate directory, but kept the same?
[package.metadata.bundle]
additional_source_files = ["build.rs", "ui/*"]There was a problem hiding this comment.
I think the best way to do this is to include everything in the workspace/project by default (except the target and .git folders), and then have a deny list of files and folders the user doesn't want to include. That way it'll just work, while still allowing them to trim the size.
| "{description}", | ||
| settings | ||
| .long_description() | ||
| .unwrap_or("Flatpak Written in Rust"), |
There was a problem hiding this comment.
This should be the actual description as well
|
Ok, so now the work I still need to do is:
|
|
I'm wondering if it would be worth redirecting efforts over to the new kid on the block cargo-packager and adding Flatpak support over there, since there is much quicker development and support. Either way, thank you for all the effort. |
3 participants
I saw #105 and figured I would try to work on this. I haven't finished it yet. cargo fmt gives me a bunch of
Warning: Unknown configuration option, so you might have to fix the code formattingTodo