fix: remove unnecessary cd command from composer install in bootstrap#11
Open
dannorthern wants to merge 1 commit into
Open
fix: remove unnecessary cd command from composer install in bootstrap#11dannorthern wants to merge 1 commit into
dannorthern wants to merge 1 commit into
Conversation
The run_composer_install() function was failing because it was trying to change directory on the host before running lando composer install, but lando runs commands inside the container where the project directory is already mounted. Removed the cd command to fix the "composer.json not found" error during setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run_composer_install() function was failing because it was trying to change directory on the host before running lando composer install, but lando runs commands inside the container where the project directory is already mounted. Removed the cd command to fix the "composer.json not found" error during setup.