This repository was archived by the owner on Nov 24, 2025. It is now read-only.
fix: remove domain overwrite on simple redirects#977
Open
crisog wants to merge 3 commits into
Open
Conversation
|
This pull request has been linked to 1 task:
|
Contributor
Author
|
Link T-14959 |
adshmh
suggested changes
Oct 19, 2022
adshmh
left a comment
adshmh
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR. A few comments to address.
crisog
changed the title
|
Link T-15008 |
|
Link T-15008 |
Contributor
Author
|
#984 ENV can be removed when this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complementary PR for #975.
The way that simple redirects were designed does not allow for a nice way to log the redirect domain, because it gets overwritten for the specific blockchain alias. This PR removes this domain overwrite to be able to log the redirect domain correctly.