Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

feat: add block height facets to sync behind log#891

Open
crisog wants to merge 2 commits into
developfrom
sync-behind-log
Open

feat: add block height facets to sync behind log#891
crisog wants to merge 2 commits into
developfrom
sync-behind-log

Conversation

@crisog

@crisog crisog commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

As of now, the block heights are only recorded in the error string. This is not very helpful to use in Datadog and we'll need it to make an strategy to balance out the sync allowance depending on how often nodes are out of sync.

@height

height Bot commented Jul 6, 2022

Copy link
Copy Markdown

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@crisog crisog requested a review from adshmh July 6, 2022 13:52
@adshmh

adshmh commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR. Does fisherman need updating with the same change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants