Fix enum value features and STRICT visibility edition 2024 - #773
Open
emcfarlane wants to merge 1 commit into
Open
emcfarlane wants to merge 1 commit into
emcfarlane wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three edition 2024 behaviors.
Enum value features were ignored. Feature lookup on
builtins.EnumFeaturesinstead ofbuiltins.EnumValueFeatures, so features set on an enum value were never applied or validated against the edition.STRICTnested visibility. protoc fixed its namespaced-enum check upstream (protocolbuffers/protobuf@1229d4a, protocolbuffers/protobuf@18561e4), so no longer need thebuggedwarning workaround. UnderSTRICT, nested messages can never be exported. A nested enum can only be exported if it is inside a top-levellocalmessage with a singlereserved 1 to max;.Source spans for
export/localtypes. protoc consumes the visibility modifier before recording a message or enum's location, so the span starts atmessage/enum. Comments still attach from the first token.