Deduplicate remote fetches for generate inputs - #4686
Merged
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
reviewed
Sep 16, 2026
doriable
left a comment
doriable
left a comment
Member
There was a problem hiding this comment.
Since this would be using an in-memory cache, we need to do some validation for the LSP on memory consumption and include that in some combination of the PR description or in a test.
emcfarlane
changed the title
Contributor
Author
|
@doriable thanks added option config for setting per command. |
doriable
approved these changes
Sep 24, 2026
doriable
left a comment
doriable
left a comment
Member
There was a problem hiding this comment.
Since we're gating this to only be used, this looks reasonable to me. Approving in advance of merge conflicts being resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds caching to remote references so buf generate now fetches each remote input once. Multiple inputs in a buf.gen.yaml that resolve to the same archive, git repository, or image previously fetched once per input. The cache is opt-in and set per command required.
Closes #4657