add: searchBySutta and TDD && suttaNumOnly Array#653
Open
DylanAustin-TheDreamer wants to merge 3 commits into
Open
add: searchBySutta and TDD && suttaNumOnly Array#653DylanAustin-TheDreamer wants to merge 3 commits into
DylanAustin-TheDreamer wants to merge 3 commits into
Conversation
✅ Deploy Preview for obu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…hist-uni.github.io into dylan-sutta-search
khemarato
reviewed
Jul 8, 2026
|
|
||
| joinedTitles = normalizeSuttaTitles(store); | ||
| suttaNumOnly = storeSuttaNumsOnly(store); | ||
| console.log(suttaNumOnly); |
Collaborator
There was a problem hiding this comment.
Please remove debugging statements before putting up PRs :)
| if (!item || item.type !== "content" || item.category !== "canon") continue; | ||
| const title = item.title || ""; | ||
| const titleJoin = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|KN|LAL|DA|MA|SA|EA|SNP|DHP|ITI|THAG|THIG|UD|NIDD|CV|BV|AP|JA|PV|VV|KP|PTS)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/\s*[:\-–]\s*.*$/, "").toLowerCase().replace(/[^a-z0-9]/g, ""); | ||
| const titleJoin = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|KN|LAL|DA|MA|SA|EA|SNP|DHP|ITI|THAG|THIG|UD|NIDD|CV|BV|AP|JA|PV|VV|KP|PTS|KHP|MV|T|MVU|VB|THAAP|SF)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/\s*[:\-–]\s*.*$/, "").toLowerCase().replace(/[^a-z0-9]/g, ""); |
Collaborator
There was a problem hiding this comment.
THAAP was a typo in the title at https://buddhistuniversity.net/content/canon/tha-ap392+cmy
I'll correct that to "Tha-Ap"
| const item = obj[i]; | ||
| if (!item || item.type !== "content" || item.category !== "canon") continue; | ||
| const title = item.title || ""; | ||
| const titleJoin = title.replace( |
Collaborator
There was a problem hiding this comment.
Why did you indent this line?
|
|
||
| function searchBySuttaNum (query, suttaNumOnly) { | ||
| var tokenResults = []; | ||
| const normalizedQuery = query.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/[^a-z0-9]/g, "").replace(/\./g, "").replace(/\s+/g, "").replace(" ", "").toLowerCase(); |
Collaborator
There was a problem hiding this comment.
Is all this normalizing necessary? What specific user queries are you trying to handle with this logic? Can you think of any queries for which this logic will do the wrong thing?
| var tokenResults = []; | ||
| const normalizedQuery = query.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/[^a-z0-9]/g, "").replace(/\./g, "").replace(/\s+/g, "").replace(" ", "").toLowerCase(); | ||
| for (var i in suttaNumOnly){ | ||
| const item = suttaNumOnly[i] |
Collaborator
There was a problem hiding this comment.
missing the semicolon on the end
| } | ||
| finalResults = results.length ? results : findOneWordSuttaTitleMatches(data.q.trim(), joinedTitles); | ||
|
|
||
| let hasNumber = /\d/.test(data.q.trim()); |
Collaborator
There was a problem hiding this comment.
There's no need to trim a \d test
|
|
||
| let hasNumber = /\d/.test(data.q.trim()); | ||
|
|
||
| if(hasNumber){ |
Collaborator
There was a problem hiding this comment.
Can you think of any queries where this will do the wrong thing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality for searching nikaya references indefinitely.
We have 2 functions and a new array. StoreSuttaNumsOnly which stores objects in an array called suttaNumOnly.
Then we detect whether or not the user has input a number, then run searchBySuttaNum function. Just like how we handled joinsuttatitles but for nikaya indexes only this time.
This may have implications for other types of content with numbers. Maybe you can review this and help me understand how to make this feature better.
Although I have realized, a lot of our content titles use words for numbers - like one, six, twenty. if this is consistent, then this method might be perfectly fine.