Repository navigation
Conversation
esabol
force-pushed
the
fix-failing-tests-on-strawberry-perl
branch
from
September 30, 2026 01:36
dbdc294 to
a444e81
Compare
These tests are perhaps best skipped on Windows as its case insensitivity means |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the two failing tests in
t/02attribs.tdiscovered by @shawnlaffan in #96 (comment) when preparing Strawberry Perl 5.44 for release. A fix identical to this pull request was confirmed to have fixed the issue on Strawberry Perl in #96 (comment).Notes on the changes to
t/02attribs.t:The added
$dbh->rollback()s ensure a clean transaction state before the nextParamValueschecks That way the tests do not depend on the “commands ignored until end of transaction block” behavior that is fragile on Windows.The
(SELECT 1/0)is evaluated at execution time, after binds, soShowErrorStatementstill gets a fullParamValuesmap. The same pattern works for both $sth->execute and $dbh->do.Regarding the changes to
t/04misc.t:This is a test expectation issue caused by Windows' case-insensitive filesystems. I'm surprised we haven't seen a report of this on macOS? We could just skip these tests if
$^O =~ /Win32|msys|cygwin/i(and macOS/Darwin?), but I have chosen to add the error messages reported on Strawberry Perl to the expected regex.