Repository navigation
Scraper: cap research at N new topics, not N including seen ones - #53
Merged
Merged
Conversation
The per-run cap was applied before already-researched topics were filtered
out. Search discovery returns ~80 names in a stable order, so after two
runs the first 8 were all seen and later runs researched nothing new
("8 topics, 6 skipped, 2 candidates written"). Filter seen topics first
and stop once N new ones are queued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52, found while checking the first dev runs.
The scraper's per-run cap (
MAX_TOPICS_PER_RUN) was applied before already-researched topics were filtered out. Search discovery returns ~80-90 names in a stable order, so once the first 8 were researched, later runs skipped them and researched nothing new (dev log: "8 topics, 6 skipped, 2 candidates written").Now seen topics are filtered first and the run stops once N new topics are queued.
Dev results for #52 were good: 10 named, high-confidence candidates (Bromethalin, Metaldehyde, Zinc phosphide, ...), no footer junk.