fix(consensus): activate Taproot and close second-pass audit gaps#59
Merged
Conversation
Enable BIP341 (ALWAYS_ACTIVE) on all networks so witness v1/bech32m outputs are fully validated instead of accepting arbitrary witnesses. Hardens the May audit remediation branch with LWMA and Dilithium activation functional tests, corrected Dilithium tapscript sigop checks, Taproot empty-witness regression coverage, and Python test framework constants matching 8 MW / 15k script element limits. Adds Dilithium fuzz coverage, wallet cross-type and encryption tests, quick-test.sh, and verification notes for BTQ-AUDIT-2026-028 onward. Co-authored-by: Cursor <cursoragent@cursor.com>
BarneyChambers
added a commit
that referenced
this pull request
Jun 9, 2026
… interpreter PR #57 changed the GetTxSigOpCost P2WPKH/P2SH-P2WPKH assertions to expect SCRIPT_ERR_WITNESS_PUBKEYTYPE, matching its own (now superseded) witness program handling. The merge adopted master/#59's VerifyWitnessProgram, which gates the witness-pubkeytype check behind SCRIPT_VERIFY_WITNESS_PUBKEYTYPE (not in the test's flags), so a 33-byte non-compressed witness pubkey now fails the OP_EQUALVERIFY (HASH160 mismatch) instead. Restore the upstream/ master expectation of SCRIPT_ERR_EQUALVERIFY so the test matches the interpreter we kept. Fixes a sigopcount_tests abort + arg-pollution cascade.
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable BIP341 (ALWAYS_ACTIVE) on all networks so witness v1/bech32m outputs are fully validated instead of accepting arbitrary witnesses.
Hardens the May audit remediation branch with LWMA and Dilithium activation functional tests, corrected Dilithium tapscript sigop checks, Taproot empty-witness regression coverage, and Python test framework constants matching 8 MW / 15k script element limits.
Adds Dilithium fuzz coverage, wallet cross-type and encryption tests, quick-test.sh, and verification notes for BTQ-AUDIT-2026-028 onward.