Skip to content

netsync: avoid clock tick race in sync state test #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starius wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

netsync: avoid clock tick race in sync state test #2564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions netsync/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,9 +869,10 @@ func syncSendHeaders(t *testing.T, sm *SyncManager,

t.Helper()

// Record the progress time set by startIBD so we can verify
// that handleHeadersMsg advances it.
progressBefore := sm.lastProgressTime
// Reset the progress time to a zero sentinel so the assertion below
// verifies that handleHeadersMsg writes it without depending on the
// system clock advancing between calls to time.Now.
sm.lastProgressTime = time.Time{}

headers := wire.NewMsgHeaders()
for _, block := range blocks {
Expand All @@ -887,7 +888,7 @@ func syncSendHeaders(t *testing.T, sm *SyncManager,
_, bestHeaderHeight := sm.chain.BestHeader()
require.Equal(t, int32(totalBlocks), bestHeaderHeight)

require.True(t, sm.lastProgressTime.After(progressBefore),
require.False(t, sm.lastProgressTime.IsZero(),
"handleHeadersMsg should update lastProgressTime")

wantRequested := make(map[chainhash.Hash]struct{}, len(blocks))
Expand Down
Loading