Repository navigation
Fix LM-919 review follow-ups - #43
Merged
Merged
Conversation
Engine - Start and Stop share one pending start; Stop cancels hits queued in the lookahead, and resume failures no longer escape. - Choked kicks and hats stop their sources; a stalled tick skips missed steps instead of stacking them; the hidden-tab playhead queue stays small; a held chord stops droning when no synth step can fire. - Firefox keeps the synth's decay when a note is released early. Controls and session - Changes that alter nothing no longer add undo steps. - The first held key fills a rhythm that plays at the current SPEED. - LED groups use arrow keys; Undo keeps focus; Escape cancels a typed tempo; trackpad swipes move knobs smoothly; drags don't select text. - Screen readers hear Start/Stop once and the octave-shifted key names. - The share link trails edits by 250 ms and survives browser limits. Docs and assets - Remove the unused 808 samples and fix stale README, docs, and comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The LM-919 review (#42) left a list of non-blocking issues: start/stop edge cases, Firefox and background-tab glitches, undo and keyboard rough edges, a silent synth at SPEED 1/4, unthrottled share-link rewrites, and stale docs and assets.
What changed
How you verified
7efa5a7. RunScreenshots
Before:
7e12648· After:7efa5a7· Captured at 2× in Chrome for TestingBB-Thread-ID: thr_d58s3peww2
🤖 Generated with Claude Code