Skip to content

Fix LM-919 review follow-ups - #43

Merged
brsbl merged 1 commit into
mainfrom
bb/review-follow-ups
Oct 4, 2026
Merged

brsbl merged 1 commit into
mainfrom
bb/review-follow-ups

Conversation

@brsbl

@brsbl brsbl commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Human comments

What was wrong

The LM-919 review (#42) left a list of non-blocking issues: start/stop edge cases, Firefox and background-tab glitches, undo and keyboard rough edges, a silent synth at SPEED 1/4, unthrottled share-link rewrites, and stale docs and assets.

What changed

  • Holding the first key at SPEED 1/4 now fills a rhythm that plays.
  • Re-clicking a lit option, or Reset on an empty grid, no longer adds an undo step.
  • LED option groups take arrow keys, and each group is one Tab stop.
  • Undo keeps keyboard focus after the last undo.
  • Escape cancels a typed tempo; Enter still applies it.
  • Trackpad swipes move knobs and faders a few notches instead of slamming them.
  • Dragging a knob or fader no longer selects page text.
  • Screen readers hear Start/Stop once and the octave-shifted key names.
  • The share link trails edits by 250 ms and survives browser rewrite limits.
  • Stop now cancels hits queued in the next 100 ms.
  • Double-clicking Start no longer leaves a stray animation loop.
  • Choked kicks and hats stop their sources instead of running silently.
  • A stalled browser tab leaves a gap instead of a burst of stacked hits.
  • A held chord stops droning when no synth step can fire.
  • Firefox keeps the synth's decay when a note is released early.
  • The unused 808 samples (11 MB) are gone, and README, docs, and comments match the code.

How you verified

  • Remote CI passed lint, typecheck, test, and build on 7efa5a7. Run
  • New tests cover undo no-ops, link tempo parsing, rate-aware fill, the envelope, and clock catch-up.
  • Chrome for Testing QA passed: arrow keys, Undo focus, Escape, wheel, Start/Stop, and link timing.

Screenshots

Before: 7e12648 · After: 7efa5a7 · Captured at 2× in Chrome for Testing

Screen / state Viewport Before After
Synth / first key held at SPEED 1/4 Desktop · 1440×900 Before: filled steps 3, 7, 11, 15 never play at 1/4 After: filled steps 1, 5, 9, 13 play at 1/4

BB-Thread-ID: thr_d58s3peww2

🤖 Generated with Claude Code

AGENT GENERATED

Engine
- Start and Stop share one pending start; Stop cancels hits queued in
  the lookahead, and resume failures no longer escape.
- Choked kicks and hats stop their sources; a stalled tick skips missed
  steps instead of stacking them; the hidden-tab playhead queue stays
  small; a held chord stops droning when no synth step can fire.
- Firefox keeps the synth's decay when a note is released early.

Controls and session
- Changes that alter nothing no longer add undo steps.
- The first held key fills a rhythm that plays at the current SPEED.
- LED groups use arrow keys; Undo keeps focus; Escape cancels a typed
  tempo; trackpad swipes move knobs smoothly; drags don't select text.
- Screen readers hear Start/Stop once and the octave-shifted key names.
- The share link trails edits by 250 ms and survives browser limits.

Docs and assets
- Remove the unused 808 samples and fix stale README, docs, and
  comments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loop-machine Ready Ready Preview Oct 4, 2026 11:10am UTC

@brsbl
brsbl merged commit 5a5a75d into main Oct 4, 2026
3 checks passed
@brsbl
brsbl deleted the bb/review-follow-ups branch October 4, 2026 11:11

This branch was successfully deployed

1 active deployment
Preview — 7efa5a70 Deployed Oct 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant