You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Detached daemon startup creates a visible console window on Windows, briefly stealing focus even in headless mode. Fixes#2918.
what changed
pass windowsHide: true when spawning the detached browse daemon
add focused coverage for the daemon spawn options
test plan
prettier --check on both changed files
ESLint on both changed files
focused daemon-spawn source regression
git diff --check
The focused Vitest file could not collect locally because the package-scoped install did not include the built @browserbasehq/stagehand workspace artifact; building that unrelated workspace package exceeded the runner's resource limit.
Summary by cubic
Fixes#2918: the detached browse daemon no longer opens a visible console window on Windows that briefly steals focus, even in headless mode. The daemon now spawns with windowsHide: true, and a regression test covers the spawn option.
Written for commit 45c084b. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
Detached daemon startup creates a visible console window on Windows, briefly stealing focus even in headless mode. Fixes #2918.
what changed
windowsHide: truewhen spawning the detached browse daemontest plan
prettier --checkon both changed filesgit diff --checkThe focused Vitest file could not collect locally because the package-scoped install did not include the built
@browserbasehq/stagehandworkspace artifact; building that unrelated workspace package exceeded the runner's resource limit.Summary by cubic
Fixes #2918: the detached browse daemon no longer opens a visible console window on Windows that briefly steals focus, even in headless mode. The daemon now spawns with
windowsHide: true, and a regression test covers the spawn option.Written for commit 45c084b. Summary will update on new commits.