You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prevents formatter race condition: Running protocol build inside pnpm check causes stagehand.v4.json generation to race against root oxfmt --check ., leading to false formatting failures. Pre-building the protocol ensures the generated schema is formatted before formatting checks run.
Decouples CLI tests from typecheck: CLI tests require built SDK and Browse artifacts (dist/). Explicitly building browse guarantees CLI tests remain robust and independent of any incidental dependencies in evals#typecheck.
Eliminates unnecessary build steps: Avoids compiling unrelated deliverables (such as the evals bundle) during Check.
Verification
Fork CI run (35338910737): Check, Build, TypeScript unit, and all 32 integration jobs passed.
turbo run build --filter=browse hits Turbo cache in 51ms during normal runs while serving as a reliable guardrail.
Local verification: pnpm check, pnpm test:unit, and pnpm --filter browse test:cli passed cleanly.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
external-contributor
Summary
Replaces the full
pnpm buildin theCheckworkflow job with targeted builds:@browserbasehq/stagehand-protocolbeforepnpm checkand runs the schema drift diff.browsebefore running CLI tests (pnpm --filter browse test:cli).Why
pnpm checkcausesstagehand.v4.jsongeneration to race against rootoxfmt --check ., leading to false formatting failures. Pre-building the protocol ensures the generated schema is formatted before formatting checks run.dist/). Explicitly buildingbrowseguarantees CLI tests remain robust and independent of any incidental dependencies inevals#typecheck.Check.Verification
Check,Build,TypeScript unit, and all 32 integration jobs passed.turbo run build --filter=browsehits Turbo cache in 51ms during normal runs while serving as a reliable guardrail.pnpm check,pnpm test:unit, andpnpm --filter browse test:clipassed cleanly.