Conversation
…iple URL fragments (hash parameters) and also removes unnecessary parameters from the query string and URL fragments (_gl + cookieconsent). Tested and passed preliminary checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update proposes solution to issues #59 and #61. This adds support for multiple URL fragments (hash parameters) and improves URL sanitisation in the tracked link builder so _gl and cookieconsent are removed from both the main query string and any query-like content inside URL fragments before a new tracked link is generated.
The update heavily modifies the previous fragment-handling fix to keep fragment parsing safe while preserving valid anchor content.
Live test available here: https://dev.allaround.digital/clients/brc/link-builder/index.html
Apologies for the previous pull request attempts. I realized it didn't make sense to split the two changes into two different branches and PRs, because they're closely related and it was more efficient to make the changes all at once.