Skip to content

parquetio: Remove value reader #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattnibs wants to merge 1 commit into
base: anyio-reader-vio
Choose a base branch
from
Open

parquetio: Remove value reader #7108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions sio/parquetio/reader.go
View file
Open in desktop

This file was deleted.

15 changes: 15 additions & 0 deletions sio/parquetio/vectorreader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package parquetio

import (
"context"
"errors"
"fmt"
"io"
"slices"
Expand All @@ -14,6 +15,7 @@ import (
"github.com/apache/arrow-go/v18/parquet"
"github.com/apache/arrow-go/v18/parquet/file"
"github.com/apache/arrow-go/v18/parquet/pqarrow"
"github.com/apache/arrow-go/v18/parquet/schema"
"github.com/brimdata/super"
"github.com/brimdata/super/pkg/byteconv"
"github.com/brimdata/super/pkg/field"
Expand All @@ -24,6 +26,9 @@ import (
"golang.org/x/exp/constraints"
)

//lint:ignore ST1005 Parquet should be capitalized
var errNotSeekable = errors.New("Parquet format requires seekable input")

type VectorReader struct {
ctx context.Context
sctx *super.Context
Expand Down Expand Up @@ -439,3 +444,13 @@ func convertSlice[Out, In constraints.Float | constraints.Integer](in []In) []Ou
}
return out
}

func columnIndexes(schema *schema.Schema, fields []field.Path) []int {
var indexes []int
for _, f := range fields {
if i := schema.ColumnIndexByName(f.String()); i >= 0 {
indexes = append(indexes, i)
}
}
return indexes
}
Loading