anyio.NewReader: Return vio.Puller#7105
Open
mattnibs wants to merge 1 commit into
Open
Conversation
mattnibs
force-pushed
the
anyio-reader-vio
branch
2 times, most recently
from
44d0809 to
73ff476
Compare
nwt
reviewed
Jul 10, 2026
This commit changes anyio.NewReader so that a vio.Puller is returned. CSUP and Parquet return the native Vector Puller implementation, all other formats convert the input into vectors using sbuf.Dematerializer. This change has an intended downstream consequence that CSUP and Parquet files read anywhere will remain in their native vector format and not get converted to sequential then back to vectors as is the current state of affairs.
mattnibs
force-pushed
the
anyio-reader-vio
branch
from
73ff476 to
79a1bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes anyio.NewReader so that a vio.Puller is returned. CSUP and Parquet return the native Vector Puller implementation, all other formats convert the input into vectors using sbuf.Dematerializer. This change has an intended downstream consequence that CSUP and Parquet files read anywhere will remain in their native vector format and not get converted to sequential then back to vectors as is the current state of affairs.