feat: use window DesktopMediaID when no source ID specified OS-15494#144
Open
t-bashir-bs wants to merge 1 commit into
Open
feat: use window DesktopMediaID when no source ID specified OS-15494#144t-bashir-bs wants to merge 1 commit into
t-bashir-bs wants to merge 1 commit into
Conversation
When getUserMedia is called with chromeMediaSource: 'desktop' but no chromeMediaSourceId, the fallback of TYPE_SCREEN with kFullDesktopScreenId (-1) hangs indefinitely on ozone/wayland + nexus. Instead, look up the NativeWindow for the requesting WebContents via NativeWindowRelay and use its GetDesktopMediaID(), which returns a TYPE_WINDOW ID. This is the same ID returned by BrowserWindow.getMediaSourceId() and works correctly on all platforms including ozone/wayland + nexus. The TYPE_SCREEN/-1 path is retained as a fallback for cases where no NativeWindow can be found.
|
Does this mean we can't do full screen desktop capture? Have you tried this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When getUserMedia is called with chromeMediaSource: 'desktop' but no chromeMediaSourceId, the fallback of TYPE_SCREEN with kFullDesktopScreenId (-1) hangs indefinitely on ozone/wayland + nexus.
Instead, look up the NativeWindow for the requesting WebContents via NativeWindowRelay and use its GetDesktopMediaID(), which returns a TYPE_WINDOW ID. This is the same ID returned by BrowserWindow.getMediaSourceId() and works correctly on all platforms including ozone/wayland + nexus.
The TYPE_SCREEN/-1 path is retained as a fallback for cases where no NativeWindow can be found.
Checklist
npm testpassesRelease Notes
Notes: