fix(runtime/darwin): export _rt_argc/_rt_argv/_rt_envp symbols#316
Merged
Conversation
the darwin runtime startup globals lacked the #[symbol(...)] annotations the linux runtime carries, so the start inline-asm storing into them could not resolve the symbols and the link failed with 'undefined symbol: _rt_argc'. annotate all three on both darwin arch runtimes, mirroring src/runtime/linux/x86_64.mach. Closes #314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
#[symbol(...)]annotations to the darwin runtime startup globals on both arches, mirroringsrc/runtime/linux/x86_64.mach.Without the exports, the
startinline-asm that stores into_rt_argc/_rt_argv/_rt_envpcannot resolve the symbols and the darwin link fails withundefined symbol: _rt_argc, blocking any mach-built darwin program.src/runtime/darwin/x86_64.machsrc/runtime/darwin/aarch64.machParity fix only; no behavioral change on linux. Darwin link advances past this error once applied (per issue verification).
Closes #314
🤖 Generated with Claude Code