perf(string): bound str_region_equals scan to the compared region#302
Merged
Conversation
Drop the whole-source str_len(s) bounds check, which made the function O(file size). The parser calls str_region_equals per keyword probe per token via at_kw, so that strlen turned parsing quadratic. Scan only the compared region and rely on the NUL-terminator check to preserve out-of-bounds safety for valid start offsets, restoring linear-time region comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the whole-source
str_len(s)bounds check instr_region_equals, which made the function O(file size). Since the parser calls it per keyword probe per token viaat_kw, that strlen turned parsing quadratic. The loop now scans only the compared region and returns false on a NUL terminator, preserving out-of-bounds safety for valid start offsets while restoring linear-time comparison.mach test .: 563 passed, 0 failed.Closes #301