Conversation
cmalven
commented
Mar 24, 2026
cmalven
left a comment
Collaborator
Author
There was a problem hiding this comment.
@brianjhanson No rush, because we're still waiting on a couple of other Vite ecosystem plugins to make the jump to v8, but would be nice to get your eyeballs on this whenever you have a chance.
There was a problem hiding this comment.
Pull request overview
Updates this plugin repo to align with Vite 8’s migration from Rollup to Rolldown, including build tooling and documentation/playground updates to match the new configuration surface.
Changes:
- Migrate build tooling from
unbuildtotsdownand update package metadata/exports accordingly. - Update Vite config examples (README + playground) from
build.rollupOptionstobuild.rolldownOptionsand bump the playground to Vite 8. - Adjust internal typing from Rollup to Rolldown (
InputOption) to reflect the new bundler.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsdown.config.ts | Adds tsdown build configuration (ESM + d.ts generation). |
| src/utils.ts | Switches InputOption type import from rollup to rolldown. |
| playground/basic/vite.config.js | Updates example config to use build.rolldownOptions. |
| playground/basic/package.json | Bumps playground Vite dependency to ^8.0.1. |
| playground/basic/package-lock.json | Lockfile update reflecting Vite 8 + Rolldown dependency tree. |
| package.json | Switches to tsdown, updates exports/engines, and narrows Vite peer to ^8. |
| build.config.ts | Removes the previous unbuild configuration file. |
| README.md | Updates the primary example snippet to rolldownOptions. |
| .gitignore | Adds .DS_Store to ignored files. |
Files not reviewed (1)
- playground/basic/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #22