Repository navigation
fix(pydantic-ai): preserve caller-inferred agent names - #1143
Merged
Merged
Conversation
> 🤖 **This text was AI-generated.**
Pydantic AI infers an unnamed agent's name from its caller. Braintrust's
wrappers could cause that lookup to find an internal variable named
`instance`, while the outer span still had a generic name.
Run Pydantic AI's lookup in the caller's scope before starting the span.
Keep explicit names and `infer_name=False`, and defer inference for
`run_stream()` until the caller enters the stream.
For `my_agent.run_sync("hi")`, the outer and inner span names become:
```text
Before
agent_run_sync -> agent_run [instance]
After
agent_run_sync [my_agent] -> agent_run [my_agent]
```
Fixes #1139
Refs: #1141
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pydantic AI infers an unnamed agent's name from its caller. Braintrust's wrappers could cause that lookup to find an internal variable named
instance, while the outer span still had a generic name.Run Pydantic AI's lookup in the caller's scope before starting the span. Keep explicit names and
infer_name=False, and defer inference forrun_stream()until the caller enters the stream.For
my_agent.run_sync("hi"), the outer and inner span names become:Fixes #1139
Refs: #1141