Skip to content

docs(skills): codify SDK integration review checks - #1140

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-agents-md-based-on-pipecat-duplex
Nov 18, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-agents-md-based-on-pipecat-duplex

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

🤖 This text was AI-generated.

The follow-up commits on #1136 exposed gaps in our guidance for agents writing SDK integrations. This PR adds a pre-review check in AGENTS.md and documents the expected practices in the SDK integrations skill.

  • Reuse the underlying provider’s usage parser and check the recorded metrics.
  • Gate optional hooks together, skip incompatible hooks quietly, and rely on the shared patcher for idempotency.
  • Run real framework pipelines with recorded provider traffic and assert on exported spans. Check caller context after exceptions and cancellation.
  • Make session and response phases explicit, bound routing history, and verify that teardown clears tracker-owned state.

The skill validator, git diff --check, and commit hooks passed.

> 🤖 **This text was AI-generated.**

Pipecat's GPT-Live PR needed follow-up changes to preserve cache-write
metrics, exercise real pipeline behavior, and release tracker state.
Route integration work from AGENTS.md to the SDK integrations skill
so agents apply these checks before review.

```
real pipeline + recorded provider traffic -> exported spans
                                          -> tracker cleanup
```

The skill also covers reuse of usage parsers and patchers, quiet
feature detection, and explicit phases for event-driven tracing.

Refs: #1136
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit a93b233 into main Nov 18, 2026
95 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-agents-md-based-on-pipecat-duplex branch November 18, 2026 16:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T17:00:16.243849Z b43f3ba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant