fix: replace U+2192 arrows with ASCII dashes in focus-range output#19
Open
cristianorj22 wants to merge 1 commit into
Open
fix: replace U+2192 arrows with ASCII dashes in focus-range output#19cristianorj22 wants to merge 1 commit into
cristianorj22 wants to merge 1 commit into
Conversation
Three print statements in watch.py used U+2192 RIGHTWARDS ARROW to render focus-range labels (e.g. "00:30 -> 02:00"). The character can't be encoded by Windows' default cp1252 console codepage and crashes with UnicodeEncodeError — same class of issue as the emoji removal in v0.1.2. Replace with ASCII hyphen; renders cleanly across encodings and matches the report's other range separators. Affected lines: focus-range header, transcript source label when focused, and the "no transcript lines fell inside <range>" fallback. (The original local commit message in this user's clone said "fix: map channelUsername field" — that was copy-pasted by mistake from an unrelated repo and does not describe the actual diff.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three
print(...)lines inscripts/watch.pyrendered focus-range labels using U+2192 RIGHTWARDS ARROW (→). The character isn't representable in Windows' default cp1252 console codepage and triggersUnicodeEncodeError— same class of issue as the emoji removal in v0.1.2 and the UTF-8 reads in v0.1.3.Replaces
→with ASCII-in:**Focus range:**header line in the report_Source: ...:_transcript label when--start/--endare set_No transcript lines fell inside ...:_fallback when the filter returned nothingASCII hyphen renders cleanly across encodings and matches the
extracting … over <start>-<end>separator the script already uses on stderr.Test plan
python scripts/watch.py <url> --start 30 --end 60no longer raisesUnicodeEncodeErroron the focus-range bannerdist/watch.skillcleanly with the changeNotes
Diff is 3 char swaps in 3 lines — surgical, no behavior change beyond the encoding fix. No version bump or CHANGELOG entry in this PR; happy to add either if you'd prefer to land this as a patch release vs. roll it into the next batch.