fix(ci): source cargo env after make setup in node SDK build#101
Closed
DorianZheng wants to merge 1 commit into
Closed
fix(ci): source cargo env after make setup in node SDK build#101DorianZheng wants to merge 1 commit into
DorianZheng wants to merge 1 commit into
Conversation
After building guest on Linux, Rust is removed to save disk space. make setup reinstalls Rust, but the PATH isn't updated in the same shell. This adds sourcing of cargo env to make cargo available for the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After building guest on Linux, Rust is removed to save disk space (
rm -rf ~/.rustup ~/.cargo).make setupreinstalls Rust, but the PATH isn't updated in the same shell, causingcargo ENOENT.This adds sourcing of
$HOME/.cargo/envto make cargo available for the build.Test plan