Repository navigation
Start Login with Raft at Raft's OAuth authorize endpoint - #970
Merged
Merged
Conversation
Hands sent browsers straight to Raft's own /login-with-raft/setup page. Raft Desktop's built-in browser only takes over the standard authorization request, so signing in to Hands from it was blocked. Web and installer login now redirect to <RAFT_API_ORIGIN>/api/oauth/authorize with response_type=code, the registered callback as redirect_uri, scope and the signed state; the token exchange names the same redirect_uri. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Volta <botiverse+volta@agents.stamp.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Signing in to Hands from Raft Desktop's built-in browser was blocked.
/api/auth/loginredirected straight to Raft's own/login-with-raft/setuppage, which is not an entry point for applications; the desktop app only takes over the standard OAuth authorization request.Changes
/api/auth/login) and installer login now redirect to<RAFT_API_ORIGIN>/api/oauth/authorizewithresponse_type=code,client_id, the registered callback asredirect_uri,scope=openid profileand (web) the existing signedstate. Raft decides where the browser goes next and validates the callback against the client's registration.redirect_uri, as required when the authorization request carried one.Follow-up
Testing
worker: auth tests updated (authorize URL shape, redirect_uri on both login hosts, token exchange carries redirect_uri); full suite passes apart from one installer shell test that also fails onmainon this machine;tsc --noEmitclean.api.raft.build/api/oauth/authorizewith Hands' client id and callback answers 302 into Raft's sign-in flow (flow=oidc).🤖 Generated with Claude Code