Repository navigation
Update getFormatInfo and getFormatDateInfo - #100
Merged
Merged
Conversation
borgar
commented
Oct 20, 2026
borgar
commented
Owner
- getFormatInfo's currency detection now works like Excel's - Closes getFormatInfo no longer reads a quoted "$" as currency #99
- getFormatDateInfo now returns what kind of date it is (none, date, datetime, time) - Closes getFormatDateInfo should say if pattern is a date or not #77
- The two functions are no longer cached. This was just a waste of memory and allowed consumer code to poison the cache as return objects were not frozen. Own time was not enough to justify this.
- getFormatInfo's currency detection now works like Excel's - Closes #99 - getFormatDateInfo now returns what kind of date it is (none, date, datetime, time) - Closes #77 - The two functions are no longer cached. This was just a waste of memory and allowed consumer code to poison the cache as return objects were not frozen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.