chore(release): add 3.9.4 release manifest#1758
Open
himerus wants to merge 1 commit into
Open
Conversation
WalkthroughThis PR adds a release manifest file ( Changes3.9.4 Release Documentation
Possibly related PRs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
CEM API Diff
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/releases/3.9.4-manifest.json`:
- Around line 74-80: The aggregate for strategyATotal.currentBytes is
inconsistent with the components: recompute strategyATotal.currentBytes as
fullBundleJs.currentBytes (254157) + fullBundleCss.currentBytes (61286) = 315443
(or, if the intended definition differs, adjust fullBundleJs.currentBytes or
fullBundleCss.currentBytes accordingly) and update the corresponding budgets
entry in the other CDN budget file so both the aggregate
(strategyATotal.currentBytes) and the component values
(fullBundleJs.currentBytes, fullBundleCss.currentBytes) are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1e5f436e-d40c-4869-8192-ec1fb112062f
📒 Files selected for processing (1)
docs/releases/3.9.4-manifest.json
Comment on lines
+74
to
+80
| "strategyATotal": { | ||
| "description": "Aggregate Strategy A consumer payload (full JS + full CSS). This is what a page that loads the full bundle actually downloads.", | ||
| "ceilingBytes": 332800, | ||
| "warnBytes": 322560, | ||
| "currentBytes": 312832, | ||
| "currentNote": "305.5 KB gz at AAA Tier 3 epic head (was 291.1 KB at ARIA epic head; tracks fullBundleJs + fullBundleCss growth from 3.8.0 cert work)." | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if .cdn-budget.json has the same mathematical inconsistency
cat .cdn-budget.json | jq '{
fullBundleJs: .budgets.fullBundleJs.currentBytes,
fullBundleCss: .budgets.fullBundleCss.currentBytes,
strategyATotal: .budgets.strategyATotal.currentBytes,
calculated_sum: (.budgets.fullBundleJs.currentBytes + .budgets.fullBundleCss.currentBytes),
discrepancy: ((.budgets.fullBundleJs.currentBytes + .budgets.fullBundleCss.currentBytes) - .budgets.strategyATotal.currentBytes)
}'Repository: bookedsolidtech/helix
Length of output: 199
🏁 Script executed:
#!/bin/bash
# Inspect .cdn-budget.json budgeting fields related to strategyATotal
set -euo pipefail
jq '
{
budgets: .budgets,
strategyATotal_notes: (.budgets.strategyATotal // {}),
strategyATotal_all_keys: (keys_unsorted(.budgets.strategyATotal // {})),
available_components_under_budgets: (keys_unsorted(.budgets))
}
' .cdn-budget.jsonRepository: bookedsolidtech/helix
Length of output: 432
🏁 Script executed:
#!/bin/bash
set -euo pipefail
jq '
{
strategyATotal: .budgets.strategyATotal,
fullBundleJs: .budgets.fullBundleJs,
fullBundleCss: .budgets.fullBundleCss,
strategyATotal_currentBytes: .budgets.strategyATotal.currentBytes,
fullBundleSum: (.budgets.fullBundleJs.currentBytes + .budgets.fullBundleCss.currentBytes),
discrepancy: ((.budgets.fullBundleJs.currentBytes + .budgets.fullBundleCss.currentBytes) - .budgets.strategyATotal.currentBytes),
all_budget_currentBytes: (
.budgets
| to_entries
| map(
{
key: .key,
currentBytes: (.value.currentBytes // null)
}
)
| map(select(.currentBytes != null))
| sort_by(.currentBytes)
)
}
' .cdn-budget.jsonRepository: bookedsolidtech/helix
Length of output: 1993
🏁 Script executed:
#!/bin/bash
set -euo pipefail
jq '
.budgets
| to_entries
| map({key: .key, currentBytes: (.value.currentBytes // null)})
| sort_by(.key)
' .cdn-budget.jsonRepository: bookedsolidtech/helix
Length of output: 320
Fix CDN budget aggregate math for strategyATotal
In docs/releases/3.9.4-manifest.json (lines 74-80), strategyATotal.currentBytes is 312832, but fullBundleJs.currentBytes (254157) + fullBundleCss.currentBytes (61286) equals 315443 (discrepancy 2611 bytes). The same mismatch exists in .cdn-budget.json (and there are no other budgets.* entries to account for it), so either the aggregate calculation or the “full JS + full CSS” definition needs adjustment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/releases/3.9.4-manifest.json` around lines 74 - 80, The aggregate for
strategyATotal.currentBytes is inconsistent with the components: recompute
strategyATotal.currentBytes as fullBundleJs.currentBytes (254157) +
fullBundleCss.currentBytes (61286) = 315443 (or, if the intended definition
differs, adjust fullBundleJs.currentBytes or fullBundleCss.currentBytes
accordingly) and update the corresponding budgets entry in the other CDN budget
file so both the aggregate (strategyATotal.currentBytes) and the component
values (fullBundleJs.currentBytes, fullBundleCss.currentBytes) are consistent.
Contributor
Bundle Size Report
✅ All 81 components within budget 📦 Full report — 81 components
Total: 367.09 KB / 200 KB budget ❌ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-publish manifest for
3.9.4. Auto-opened by the publish workflow after npm publish succeeded. Documentation only — safe to auto-merge.Summary by CodeRabbit
@helixui/libraryand associated packages, including icons v1.0.4, with updated CDN budget snapshots and release metadata documentation.