Feature delete user complete#42
Conversation
magley
left a comment
magley
left a comment
There was a problem hiding this comment.
Good job. I'd like for you to add a 404 page for deleted rooms (or for room-not-found in general) like we discussed privately.
magley
left a comment
magley
left a comment
There was a problem hiding this comment.
I've left a suggestion to improve UX but if you want to merge asap it's fine as-is.
|
|
||
| <Message v-show="error.length > 0" style="margin: 7px;" severity="error" size="medium" variant="simple">{{ error }}</Message> | ||
|
|
There was a problem hiding this comment.
If the error http response code is 404, could we add a custom message? Since this is RoomDetails, we know that a 404 means "Room not found or deleted".
There was a problem hiding this comment.
Honestly, I didn’t do that intentionally, because I thought hardcoding it wouldn’t be a smart long-term solution. But I agree it would improve UX, so I implemented it. I also handled a similar case where a reservation request remains in flight on the host side after the guest account is deleted. ff7ec2c
2 participants
Closes #6.
Also, check book-em/user-service#40 for more information.
Part of: