Skip to content

Login#9

Merged
magley merged 14 commits into
developfrom
feature-login
Jul 29, 2025
Merged

Login#9
magley merged 14 commits into
developfrom
feature-login

Conversation

@magley

@magley magley commented Jul 28, 2025

Copy link
Copy Markdown
Member

Closes #4

If you want to test manually you can use client.py. It's nicer than curl or postman.

Anyway, here's login. Make sure to unpack the keys.rar first.

Speaking of keys, they are stored in the repo's secrets so the workflow can access them (they're the same ones as from the .rar).

magley added 9 commits July 27, 2025 21:32
Forgot to include this the last time.
We use the same ports in MockerHub and I constantly have to shut down those containers when running these ones.
Notice jwt.go: the actual function is private, while its public counterpart is a function variable. I can then mock the function inside my code.

This is as close as you can get to monkey patching in Go. My only other alternative is to write interfaces which is stupid.
@magley
magley requested a review from Vasilijez July 28, 2025 10:24
@magley magley self-assigned this Jul 28, 2025
@magley magley added the feature New functional or non-functional requirement implementation. label Jul 28, 2025

@Vasilijez Vasilijez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is clear. Even though it's written in Go, you know how to write clean code. Great job.

Comment thread src/util/jwt.go Outdated
Comment thread src/util/jwt.go
Comment thread src/util/jwt.go
Comment thread keys/keygen.sh Outdated
Comment thread src/domain/error.go Outdated
Comment thread src/test/login_test.go Outdated
@magley
magley requested a review from Vasilijez July 29, 2025 08:44
@magley
magley merged commit 0a063aa into develop Jul 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functional or non-functional requirement implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants