Login#9
Merged
Merged
Conversation
Forgot to include this the last time.
We use the same ports in MockerHub and I constantly have to shut down those containers when running these ones.
Notice jwt.go: the actual function is private, while its public counterpart is a function variable. I can then mock the function inside my code. This is as close as you can get to monkey patching in Go. My only other alternative is to write interfaces which is stupid.
Vasilijez
requested changes
Jul 28, 2025
Vasilijez
left a comment
Member
There was a problem hiding this comment.
Everything is clear. Even though it's written in Go, you know how to write clean code. Great job.
Vasilijez
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
If you want to test manually you can use
client.py. It's nicer than curl or postman.Anyway, here's login. Make sure to unpack the
keys.rarfirst.Speaking of keys, they are stored in the repo's secrets so the workflow can access them (they're the same ones as from the .rar).